Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Add struct scan and simply optimise struct filter. #19425

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Nov 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

(v1,v2) > (1,2) means v1 > 1 or (v1 =1 and v2 >2), so it eq all data from (1,2)

in this pr, we add optimise for struct filter
for example :
(v1,v2,v3) > (1,2,3) if v1 ,v2, v3 all pk, we can push it down table scan((v1,v2,v3) > (1,2,3));
if v1, v2 is pk , v3 is not pk , we can push v1 v2 down table scan and add filter , the plan like :
filter(v1,v2,v3) > (1,2,3)
scan : (v1,v2) > (1,2);
Although the filter remains unchanged, the number of scans is reduced

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

save

suppoert

fmt
@graphite-app graphite-app bot requested a review from a team November 18, 2024 07:17
@xxhZs xxhZs requested a review from chenzl25 November 28, 2024 06:19
proto/batch_plan.proto Outdated Show resolved Hide resolved
proto/batch_plan.proto Outdated Show resolved Hide resolved
proto/batch_plan.proto Outdated Show resolved Hide resolved
proto/batch_plan.proto Outdated Show resolved Hide resolved
src/frontend/src/utils/condition.rs Show resolved Hide resolved
src/frontend/src/utils/condition.rs Outdated Show resolved Hide resolved
src/frontend/src/utils/condition.rs Outdated Show resolved Hide resolved
@xxhZs xxhZs requested a review from chenzl25 December 2, 2024 05:19
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some planner tests?

range_strs
}

pub fn ub_struct_to_string(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider change struct to row, since we use RowScanRange instead of StructScanRange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants