Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move more source tests to source_inline #18870

Closed

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Oct 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • rename e2e_test/source to source_legacy, also move scripts/source to this dir, to avoid ppl adding new tests here
  • move some good tests to source_inline

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan marked this pull request as ready for review October 11, 2024 08:56
@github-actions github-actions bot added the component/test Test related issue. label Oct 11, 2024
Copy link
Member Author

xxchan commented Oct 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

@xxchan xxchan force-pushed the 10-11-test_move_more_kafka_tests_to_source_inline branch from d4391f0 to e73f751 Compare October 11, 2024 09:25
@xxchan xxchan changed the title test: move more Kafka tests to source_inline test: move more source tests to source_inline Oct 11, 2024
@xxchan xxchan force-pushed the 10-11-test_move_more_kafka_tests_to_source_inline branch from 5574d82 to 528f886 Compare October 11, 2024 09:39
Base automatically changed from xxchan/move-test to main October 11, 2024 11:43
@xxchan xxchan force-pushed the 10-11-test_move_more_kafka_tests_to_source_inline branch 2 times, most recently from 48578e9 to 2b9b8d6 Compare October 11, 2024 14:45
@xxchan xxchan force-pushed the 10-11-test_move_more_kafka_tests_to_source_inline branch from 2b9b8d6 to 69750ed Compare October 14, 2024 07:49
@xxchan
Copy link
Member Author

xxchan commented Oct 14, 2024

The diff is not nice. Reapply in multiple PRs

@xxchan xxchan closed this Oct 14, 2024
@xxchan xxchan deleted the 10-11-test_move_more_kafka_tests_to_source_inline branch October 14, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant