Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): re-enable kill-meta in deterministic simulation test #18795

Closed
wants to merge 4 commits into from

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Oct 7, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Followup 1-3 of #18678 (comment)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel
Copy link
Contributor Author

kwannoel commented Oct 7, 2024

Fails background_ddl recovery test. We can fix that separately.

Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly prefer separating the changes for upgrading deps and re-enabling, but not going to block this. Approve on behalf of Cargo-lock.

@kwannoel
Copy link
Contributor Author

kwannoel commented Oct 7, 2024

Blocked, need some help for: madsim-rs/madsim#228. Opened an issue in the upstream madsim repo.

@@ -44,7 +44,7 @@ filter_stack_trace_for_all_logs() {
done
}

trap filter_stack_trace_for_all_logs ERR
# trap filter_stack_trace_for_all_logs ERR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filter_stack_trace_for_all_logs accidentally removes some useful stacktrace from madsim.

But without it, the stacktrace dump in the log file is really large, and makes the file size few hundred MB to 1GB+ previously.

So I temporarily disable it here. This change won't be merged in.

@kwannoel kwannoel marked this pull request as draft October 9, 2024 06:11
Copy link
Contributor

github-actions bot commented Dec 9, 2024

This PR has been open for 60 days with no activity.

If it's blocked by code review, feel free to ping a reviewer or ask someone else to review it.

If you think it is still relevant today, and have time to work on it in the near future, you can comment to update the status, or just manually remove the no-pr-activity label.

You can also confidently close this PR to keep our backlog clean. (If no further action taken, the PR will be automatically closed after 7 days. Sorry! 🙏)
Don't worry if you think the PR is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@kwannoel kwannoel deleted the kwannoel/enable-kill-meta branch December 9, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants