-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): re-enable kill-meta in deterministic simulation test #18795
Conversation
958a7b6
to
28a8cfb
Compare
Fails background_ddl recovery test. We can fix that separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly prefer separating the changes for upgrading deps and re-enabling, but not going to block this. Approve on behalf of Cargo-lock.
Blocked, need some help for: madsim-rs/madsim#228. Opened an issue in the upstream madsim repo. |
@@ -44,7 +44,7 @@ filter_stack_trace_for_all_logs() { | |||
done | |||
} | |||
|
|||
trap filter_stack_trace_for_all_logs ERR | |||
# trap filter_stack_trace_for_all_logs ERR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filter_stack_trace_for_all_logs
accidentally removes some useful stacktrace from madsim.
But without it, the stacktrace dump in the log file is really large, and makes the file size few hundred MB to 1GB+ previously.
So I temporarily disable it here. This change won't be merged in.
This PR has been open for 60 days with no activity. If it's blocked by code review, feel free to ping a reviewer or ask someone else to review it. If you think it is still relevant today, and have time to work on it in the near future, you can comment to update the status, or just manually remove the You can also confidently close this PR to keep our backlog clean. (If no further action taken, the PR will be automatically closed after 7 days. Sorry! 🙏) |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Followup 1-3 of #18678 (comment)
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.