Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): add es dynamic route #18698

Merged
merged 4 commits into from
Sep 25, 2024
Merged

feat(sink): add es dynamic route #18698

merged 4 commits into from
Sep 25, 2024

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Sep 25, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Similar to dynamic index, supports setting a column as a route

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@lmatz lmatz added the user-facing-changes Contains changes that are visible to users label Sep 25, 2024
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

is it possible to add an e2e test

@graphite-app graphite-app bot requested a review from a team September 25, 2024 10:22
@xxhZs xxhZs added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 45ef6c4 Sep 25, 2024
29 of 30 checks passed
@xxhZs xxhZs deleted the xxh/es-sink-route branch September 25, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants