fix(ci): fix release static build #18689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwannoel
added
ci/run-backwards-compat-tests
9 tasks
xxchan
reviewed
Sep 25, 2024
| @@ -11,7 +11,7 @@ repository = { workspace = true } | |||
| [features] | |||
| # some crates opt-in static linking, while some opt-in dynamic linking, | |||
| # so they are two features :) | |||
| rw-static-link = ["static-libz-sys", "static-lzma-sys", "static-sasl2-sys"] | |||
| rw-static-link = ["static-libz-sys", "static-lzma-sys", "static-openssl-sys", "static-sasl2-sys"] | |||
There was a problem hiding this comment.
I suggest to add a new flag, and only turn it on in binary release.
So we still enjoy the benefits of fast compile time in CI & local
lmatz
approved these changes
Sep 25, 2024
kwannoel
added
need-cherry-pick-release-1.10
|
Weird that it doesn't cherry-pick 😆 |
kwannoel
added a commit
that referenced
this pull request
Sep 25, 2024
9 tasks
kwannoel
added a commit
that referenced
this pull request
Sep 25, 2024
9 tasks
kwannoel
added a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
We revert to using vendored openssl. That's because the release environment does not have openssl's static library (libssl.a) in its package repository (dnf).
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.