Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): adapt time travel cache to partial checkpoint #18646

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Sep 23, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

After partial checkpoint, the time travel's hummock version cache should use (table_id, epoch) as key rather than original epoch.
The cache is necessary because a batch query may trigger many iterators in a compute node due to multiple vnodes.
This PR also optimizes the lock used in cache implementation.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@zwang28 zwang28 requested a review from wenym1 September 23, 2024 14:57
@graphite-app graphite-app bot requested a review from a team September 23, 2024 14:57
@zwang28 zwang28 changed the title Wangzheng/refactor time travel cache refactor(storage): adapt time travel cache to partial checkpoint Sep 23, 2024
@zwang28 zwang28 requested a review from wenym1 September 24, 2024 07:30
@zwang28 zwang28 requested a review from wenym1 September 24, 2024 09:01
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zwang28 zwang28 enabled auto-merge September 24, 2024 09:13
@zwang28 zwang28 added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 29adeb9 Sep 24, 2024
30 of 31 checks passed
@zwang28 zwang28 deleted the wangzheng/refactor_time_travel_cache branch September 24, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants