Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): fix type conversion #18638

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix(meta): fix type conversion #18638

merged 1 commit into from
Sep 23, 2024

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Sep 23, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The original incorrect i32 to u32 conversion causes error in postgres meta backend, but not sqlite meta backend.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@zwang28 zwang28 added need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged and removed type/fix Bug fix ci/run-e2e-single-node-tests labels Sep 23, 2024
@zwang28 zwang28 enabled auto-merge September 23, 2024 09:10
@zwang28 zwang28 added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 9231782 Sep 23, 2024
40 of 41 checks passed
@zwang28 zwang28 deleted the wangzheng/fix_table_option branch September 23, 2024 10:00
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants