-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compaction): introduce new task status for serverless compaction #18575
Conversation
@@ -358,6 +358,10 @@ message CompactTask { | |||
TRACK_SST_OBJECT_ID_FAILED = 12; | |||
NO_AVAIL_CPU_RESOURCE_CANCELED = 13; | |||
HEARTBEAT_PROGRESS_CANCELED = 14; | |||
|
|||
// for serverless compaction | |||
SERVERLESS_SEND_FAIL_CANCELED = 15; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will serverless compaction controller add more error codes in the future? I am thinking whether we should have one error code only for all serverless compaction controller error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will serverless compaction controller add more error codes in the future?
I think it's possible, but not in a near future since the serverless protocol won't change frequently.
I am thinking whether we should have one error code only for all serverless compaction controller error.
I'm fine if the error message isn't lost. But seems we rely on the error code to tell the error kind, I think we'd better add more when necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it depends on whether we introduce more state to the compact task, e.g. table_catalog. As we iterate through the logic of the compact task, we may introduce more corresponding error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…#18575) (#18605) Co-authored-by: Li0k <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
related to https://github.com/risingwavelabs/risingwave-extensions/blob/main/pkg/compaction/drive/driver.go
The driver changes the task status in two ways
This PR introduces a separate task status type to serve the serverless compaction module, to make it easier to distinguish the source of the error.
cloud side: https://github.com/risingwavelabs/risingwave-extensions/issues/66
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.