refactor(storage): make HummockVersion a generic struct #18478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The in-memory
HummockVersion
struct has many interdependent sub types, e.g. Levels, EpochNewChangeLog, etc.There're cases we want a similar
HummockVersion
struct but with only theSstableInfo
replaced. For instance, storing eitherSstableId
orArc<SstableInfo>
instead ofSstableInfo
can significantly reduce the memory footprint.This pull request introduces a generic parameter to
HummockVersion
, allowing the use ofSstableInfo
to be replaced with a more flexible type. All original typesXX
are made generic and renamed toXXCommon<T>
.Current there're two concrete types:
HummockVersionCommon<SstableInfo>
, aliasHummockVersion
;HummockVersionCommon<SstableIdInVersion>
, which is used by time travel.To introduce a new type, just implement
From
trait. Check outtime_travel.rs
for example.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.