Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error): fix sinkError and connector error #18425

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix(error): fix sinkError and connector error #18425

merged 1 commit into from
Sep 5, 2024

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Sep 5, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

https://github.com/risingwavelabs/risingwave/pull/17969/files/a286d2ef8de2f17697e4f93ff0eff2c40a80b476#r1745038355

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxhZs xxhZs requested a review from xxchan September 5, 2024 09:28
@xxhZs xxhZs changed the title fix(error):fix sinkError and connector error fix(error): fix sinkError and connector error Sep 5, 2024
@xxchan xxchan requested a review from BugenZhao September 5, 2024 09:28
@graphite-app graphite-app bot requested a review from a team September 5, 2024 09:28
@xxhZs xxhZs enabled auto-merge September 5, 2024 09:31
@xxhZs xxhZs added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 1d220ee Sep 5, 2024
31 of 33 checks passed
@xxhZs xxhZs deleted the xxh/fix-error branch September 5, 2024 11:12
github-merge-queue bot pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants