Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iceberg): support drop table for nimtable #18404

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Sep 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • To implement drop table, we need to upgrade our iceberg-rust SDK.
  • The workflow of drop table:
    1. drop sink.
    2. purge iceberg table from warehouse
    3. drop iceberg table from catalog
    4. drop source
    5. drop hummock table

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chenzl25 chenzl25 requested a review from a team as a code owner September 4, 2024 07:38
@chenzl25 chenzl25 requested review from fuyufjh and removed request for a team September 4, 2024 07:38
@chenzl25 chenzl25 requested review from Li0k, hzxa21, wenym1 and xxhZs September 4, 2024 08:08
.await?;

let config = ConnectorProperties::extract(source.with_properties.clone(), false)?;
if let ConnectorProperties::Iceberg(iceberg_properties) = config {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some todo comments:

  1. Repeatable deletion to ensure system robustness in case of deletion failure
  2. Consider the order of deletion, the source should be deleted first to ensure that other sessions are no longer readable.

@chenzl25 chenzl25 merged commit d91c2e4 into nimtable_dev Sep 4, 2024
3 of 5 checks passed
@chenzl25 chenzl25 deleted the dylan/support_drop_table_for_nimtable branch September 4, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants