refactor: remove drop_actors rpc and simplify barrier worker state #18354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenym1
requested review from
shanicky,
yezizp2012,
BugenZhao,
kwannoel and
zwang28
BugenZhao
reviewed
Sep 4, 2024
| @@ -416,32 +424,27 @@ impl PartialGraphManagedBarrierState { | |||
| } | |||
| } | |||
|
|
|||
| pub(super) struct ManagedBarrierState { | |||
| pub(crate) struct ManagedBarrierState { | |||
| pub(super) actor_states: HashMap<ActorId, InflightActorState>, | |||
There was a problem hiding this comment.
May I know what "inflight" in InflightActor is for?
There was a problem hiding this comment.
It has no special meaning. I guess the name was following the InflightActorInfo previously in the meta node global barrier manager.
Comment on lines
+676
to
+678
| if let Some(actors_to_stop) = barrier.all_stop_actors() { | ||
| self.current_shared_context.drop_actors(actors_to_stop); | ||
| } |
There was a problem hiding this comment.
Can we also move this clean-up step into collect -> is_finished?
There was a problem hiding this comment.
At the beginning I implement it in this way, but later I realize that we also need to clean up the actor infos in other compute node, but the collect -> is_finished can only clean up the actor on this compute node. So now I changed to clean up here.
shanicky
approved these changes
Sep 6, 2024
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Extension of #18270.
In #18270, we spawn actor in inject barrier, and there is no not-started actor any more. In this PR, we further simplify the actor state of local barrier worker. The
NotStartedactor status is removed, and all actor related info, including join handles, are all managed in theInflightActorStateandStreamActorManagerStateis removed.The
drop_actorsrpc is removed, because there is no need to use it. The drop actor info is carried in the barrier, and the info of the dropped actor can be removed when the barrier is completed locally.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.