Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): record cloud hosted UUID #18019

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Aug 13, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

https://github.com/risingwavelabs/risingwave-cloud/pull/8212 related pr from cloud side

the pr adjust telemetry behavior: use cloud UUID if provided, use it as trackingID

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh
Copy link
Member

fuyufjh commented Aug 13, 2024

Is it possible to unify the cloud & kernel UUIDs? Saying, don't generated any UUIDs when a cloud UUID is provided

@tabVersion
Copy link
Contributor Author

Is it possible to unify the cloud & kernel UUIDs? Saying, don't generated any UUIDs when a cloud UUID is provided

I don't think so. Since we initially track clusters with tracking_id for telemetry, such migration may take some effort and seem unnecessary.
The requirement here is to track the behavior from cloud hosted clusters, I don't see a strong motivation to migrate to the cloud UUID. We still need to accept reports from on-perm clusters.

@fuyufjh
Copy link
Member

fuyufjh commented Aug 13, 2024

Is it possible to unify the cloud & kernel UUIDs? Saying, don't generated any UUIDs when a cloud UUID is provided

I don't think so. Since we initially track clusters with tracking_id for telemetry, such migration may take some effort and seem unnecessary. The requirement here is to track the behavior from cloud hosted clusters, I don't see a strong motivation to migrate to the cloud UUID. We still need to accept reports from on-perm clusters.

I feel you might need to explain again and again to everybody that cloud UUID is not telemetry UUID. Unifying them is the easiest way to avoid this burden.

Also, I said "when a cloud UUID is provided". As the cloud UUID is passed via environment variable, I think it should be easy to write such an if-else.

Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
@tabVersion tabVersion force-pushed the tab/apply-uuid-cloud branch from 8bf2003 to c012e94 Compare August 14, 2024 10:05
@tabVersion

This comment was marked as outdated.

@fuyufjh
Copy link
Member

fuyufjh commented Sep 23, 2024

Hi, is it ready for review?

@tabVersion tabVersion marked this pull request as ready for review September 25, 2024 06:03
@graphite-app graphite-app bot requested a review from a team September 25, 2024 06:20
@fuyufjh
Copy link
Member

fuyufjh commented Sep 25, 2024

I think it's probably better to modify the code of generating a tracking ID, such as

let tracking_id = match info_fetcher.fetch_telemetry_info().await {

Otherwise, the "wrong" tracking ID is still stored in TELEMETRY_TRACKING_ID and it's prone to be misused.

Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
@tabVersion tabVersion added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 2c89c24 Sep 25, 2024
29 of 30 checks passed
@tabVersion tabVersion deleted the tab/apply-uuid-cloud branch September 25, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants