-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telemetry): record cloud hosted UUID #18019
Conversation
Is it possible to unify the cloud & kernel UUIDs? Saying, don't generated any UUIDs when a cloud UUID is provided |
I don't think so. Since we initially track clusters with tracking_id for telemetry, such migration may take some effort and seem unnecessary. |
I feel you might need to explain again and again to everybody that cloud UUID is not telemetry UUID. Unifying them is the easiest way to avoid this burden. Also, I said "when a cloud UUID is provided". As the cloud UUID is passed via environment variable, I think it should be easy to write such an if-else. |
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
8bf2003
to
c012e94
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Hi, is it ready for review? |
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
I think it's probably better to modify the code of generating a tracking ID, such as
Otherwise, the "wrong" tracking ID is still stored in |
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
https://github.com/risingwavelabs/risingwave-cloud/pull/8212 related pr from cloud side
the pr adjust telemetry behavior: use cloud UUID if provided, use it as trackingID
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.