fix(connector): don't log config/props that may contain sensitive information #17079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR is a quick fix. I went through all
tracing::
in connector crate, to find any potential ones.rdkafka::ClientConfig::conf_map
is not strong-typed. This PR simply removes it from log. We may leverage secure-string in the rdkafka lib in the future.ConnectorProperties
andSinkParam
, this PR again simply removes them from log. After SECRETS hopefully there's no more sensitive info in them. The reasons why I don't leverage secure-string now areSinkParam::properties
is not strong-typed.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.