Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): use axum-embed to embed dashboard assets #16131

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Apr 3, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Based on #16129, resolve the comment.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

BugenZhao commented Apr 3, 2024

@BugenZhao BugenZhao marked this pull request as ready for review April 3, 2024 09:13
@BugenZhao BugenZhao requested a review from a team as a code owner April 3, 2024 09:13
@BugenZhao BugenZhao requested a review from xxchan April 3, 2024 09:13
@BugenZhao BugenZhao force-pushed the bz/hyper-1-dashboard branch from 1a09946 to 5cae694 Compare April 3, 2024 09:24
@BugenZhao BugenZhao force-pushed the bz/dashboard-axum-embed branch from 945e4c0 to 520d13b Compare April 3, 2024 09:25
Base automatically changed from bz/hyper-1-dashboard to main April 3, 2024 10:09
@BugenZhao BugenZhao force-pushed the bz/dashboard-axum-embed branch from 520d13b to 4af242f Compare April 4, 2024 06:01
@BugenZhao BugenZhao enabled auto-merge April 4, 2024 06:01
@BugenZhao BugenZhao added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit dc39131 Apr 4, 2024
29 of 30 checks passed
@BugenZhao BugenZhao deleted the bz/dashboard-axum-embed branch April 4, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants