-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump rumqttc from 0.22.0 to 0.24.0 #16007
Conversation
@dependabot recreate |
Bumps [rumqttc](https://github.com/bytebeamio/rumqtt) from 0.22.0 to 0.24.0. - [Release notes](https://github.com/bytebeamio/rumqtt/releases) - [Changelog](https://github.com/bytebeamio/rumqtt/blob/main/CHANGELOG.md) - [Commits](bytebeamio/rumqtt@rumqttc-0.22.0...rumqttc-0.24.0) --- updated-dependencies: - dependency-name: rumqttc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
4aaf251
to
182caf1
Compare
@@ -687,21 +687,21 @@ impl NatsCommon { | |||
|
|||
pub(crate) fn load_certs( | |||
certificates: &str, | |||
) -> ConnectorResult<Vec<tokio_rustls::rustls::Certificate>> { | |||
) -> ConnectorResult<Vec<rustls_pki_types::CertificateDer<'static>>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/rustls/rustls/releases/tag/v%2F0.22.0
New types for keys and certificates.
rustls::Certificate
has been replaced withCertificateDer
from the new rustls-pki-types crate. Likewise,rustls::PrivateKey
has been replaced withrustls_pki_types::PrivateKeyDer
. These types come in both owned and borrowed variants, like std::borrow::Cow, but some uses, like rustls::RootCertStore, required the owned (<'static>
) variant.
let cert_bytes = if let Some(path) = certificates.strip_prefix("fs://") { | ||
std::fs::read_to_string(path).map(|cert| cert.as_bytes().to_owned())? | ||
} else { | ||
certificates.as_bytes().to_owned() | ||
}; | ||
|
||
rustls_pemfile::certs(&mut cert_bytes.as_slice()) | ||
.map(|cert| Ok(tokio_rustls::rustls::Certificate(cert?.to_vec()))) | ||
.map(|cert| Ok(cert?)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workarounds by #15619 no longer needed
root_cert_store | ||
.add(&tokio_rustls::rustls::Certificate(cert.to_vec())) | ||
.unwrap(); | ||
root_cert_store.add(cert).unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workarounds by #15620 no longer needed
let builder = tokio_rustls::rustls::ClientConfig::builder() | ||
.with_safe_defaults() | ||
.with_root_certificates(root_cert_store); | ||
let builder = rustls::ClientConfig::builder().with_root_certificates(root_cert_store); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/rustls/rustls/releases/tag/v%2F0.22.0
ConfigBuilder::with_safe_defaults
- calls to this can simply be deleted since safe defaults are now implicit.
Bumps rumqttc from 0.22.0 to 0.24.0.
Release notes
Sourced from rumqttc's releases.
Commits
b8766e1
chore: release rumqttc v0.24.02ed9ea6
ci(actions): prevent "out of space" error on github actions ubuntu image (#804)70d0cf9
feat(rumqttd): assign random client identifier to clients (#709)b756ffb
ci(actions): disable incremental compilation to save space (#803)ee07a9e
feat(rumqttd): add Sec1Key and ignore non key items (#802)baa9341
ci(actions): implement code coverage (#800)f7c7793
feat(rumqttd): async auth function (#798)12595e8
chore: update dependencies (#799)09fd763
chore(rumqttc): update rustls and friends (#790)d348710
chore(rumqttd): update rustls and friends (#795)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)