-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): support AS OF syntax #15849
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Actually, it is not a user-facing in this PR, because I ban the possible way to use |
Ignore the earlier comment, this is just syntax change, so it will just get rejected as an error if we add planner test. We can add it subsequently once we add the backend side. Wonder if we have some docs / RFC for time travel query within RW. LGTM! |
It would be used to iceberg source first, since iceberg source currently only support COW read, we need to give users a way to specify a specific snapshot so that RisingWave can read it. |
@chenzl25 Looks like there's no need to update the documentation, right? Thanks. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Support FOR [SYSTEM_TIME | SYSTEM_VERSION] AS OF [STRING | NUMBER]
syntax.Support FOR SYSTEM_TIME AS OF PROCTIME()
.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.