Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support AS OF syntax #15849

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chenzl25 chenzl25 changed the title feat(frontend): support as of syntax feat(frontend): support AS OF syntax Mar 21, 2024
@kwannoel

This comment was marked as outdated.

@kwannoel kwannoel added the user-facing-changes Contains changes that are visible to users label Mar 22, 2024
@chenzl25
Copy link
Contributor Author

Could we have some planner tests? Thanks! And also need update release note since it's user-facing.

Actually, it is not a user-facing in this PR, because I ban the possible way to use AS OF for table scan and source. We will turn it on in the following PR

@kwannoel
Copy link
Contributor

kwannoel commented Mar 22, 2024

Ignore the earlier comment, this is just syntax change, so it will just get rejected as an error if we add planner test. We can add it subsequently once we add the backend side.

Wonder if we have some docs / RFC for time travel query within RW.

LGTM!

@chenzl25
Copy link
Contributor Author

Ignore the earlier comment, this is just syntax change, so it will just get rejected as an error if we add planner test. We can add it subsequently once we add the backend side.

Wonder if we have some docs / RFC for time travel query within RW.

LGTM!

It would be used to iceberg source first, since iceberg source currently only support COW read, we need to give users a way to specify a specific snapshot so that RisingWave can read it.

@chenzl25 chenzl25 enabled auto-merge March 22, 2024 06:51
@chenzl25 chenzl25 added this pull request to the merge queue Mar 22, 2024
Merged via the queue into main with commit bd9dcfc Mar 22, 2024
26 of 27 checks passed
@chenzl25 chenzl25 deleted the dylan/support_as_of_for_iceberg branch March 22, 2024 07:25
@hengm3467
Copy link
Contributor

@chenzl25 Looks like there's no need to update the documentation, right? Thanks.

@chenzl25
Copy link
Contributor Author

@chenzl25 Looks like there's no need to update the document, right? Thanks.

Yes, no need to update the documentation for the current PR.
Only after we use this syntax for iceberg and then we need to update the document. #15866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants