-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): simplify user error metrics #15544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuyufjh
commented
Mar 8, 2024
// report to error metrics | ||
let context = parser.source_ctx(); | ||
GLOBAL_ERROR_METRICS.user_source_error.report([ | ||
// TODO(eric): output ConnectorError's variant as label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try in next PR. #15557
BugenZhao
approved these changes
Mar 8, 2024
StrikeW
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR aims at simplifying the streaming error reporting. See context at #15192 (comment).
The current error handling is complicated and over-designed. Many usage of error metrics were incorrect, such as, not correctly combined with
ErrorSuppressor
.The major change of this PR is removing the
error_msg
from error metrics. From now on, these error metrics will only be used as a quick view for checking whether there are some errors happened. To know the exact problems i.e. error messages, users are supposed to inspect the logs.Besides, consolidated the error metrics from 5 to 3, as proposed in #15192 as well.
close #15192
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.