Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): simplify user error metrics #15544

Merged
merged 10 commits into from
Mar 11, 2024
Merged

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Mar 8, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR aims at simplifying the streaming error reporting. See context at #15192 (comment).

The current error handling is complicated and over-designed. Many usage of error metrics were incorrect, such as, not correctly combined with ErrorSuppressor.

The major change of this PR is removing the error_msg from error metrics. From now on, these error metrics will only be used as a quick view for checking whether there are some errors happened. To know the exact problems i.e. error messages, users are supposed to inspect the logs.

Besides, consolidated the error metrics from 5 to 3, as proposed in #15192 as well.

close #15192

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

// report to error metrics
let context = parser.source_ctx();
GLOBAL_ERROR_METRICS.user_source_error.report([
// TODO(eric): output ConnectorError's variant as label
Copy link
Member Author

@fuyufjh fuyufjh Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try in next PR. #15557

@fuyufjh fuyufjh added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit e27d13c Mar 11, 2024
28 of 29 checks passed
@fuyufjh fuyufjh deleted the eric/refactor_user_error_metrics branch March 11, 2024 03:18
@zwang28 zwang28 mentioned this pull request Apr 2, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: deprecate the old user-error reporting via Prometheus
3 participants