Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sink): fix starrocks sink array check #15471

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Mar 5, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In our implementation of starrocks sink, the type of the array stored in table nformation_schema.columns is UNKNOWN, which was recently fixed by starrocks, so we are fixing it as well, and we are still keeping UNKNOWN for the sake of compatibility with the old version.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxhZs xxhZs requested a review from wenym1 March 5, 2024 11:09
@github-actions github-actions bot added the type/fix Bug fix label Mar 5, 2024
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxhZs xxhZs added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit d34c7d9 Mar 5, 2024
28 of 29 checks passed
@xxhZs xxhZs deleted the xxh/fix-starrocks-array branch March 5, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants