Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): unblock fetch_watermarks in rdkafka #15465

Merged
merged 5 commits into from
Apr 1, 2024

Conversation

wangrunji0408
Copy link
Contributor

Signed-off-by: Runji Wang [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

cherry-pick #15461 to release-1.7

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408 wangrunji0408 requested a review from tabVersion March 5, 2024 09:52
@wangrunji0408 wangrunji0408 requested a review from a team as a code owner March 5, 2024 09:52
@github-actions github-actions bot added the type/fix Bug fix label Mar 5, 2024
@wangrunji0408 wangrunji0408 changed the title fix(connector): unblock fetch_watermarks in rdkafka (release-1.7) fix(connector): unblock fetch_watermarks in rdkafka (release-1.7) Mar 5, 2024
@wangrunji0408 wangrunji0408 enabled auto-merge (squash) March 5, 2024 09:53
@wangrunji0408 wangrunji0408 changed the title fix(connector): unblock fetch_watermarks in rdkafka (release-1.7) fix(connector): unblock fetch_watermarks in rdkafka Mar 5, 2024
@wangrunji0408 wangrunji0408 disabled auto-merge March 5, 2024 09:53
@wangrunji0408 wangrunji0408 enabled auto-merge (squash) March 5, 2024 09:53
auto-merge was automatically disabled March 21, 2024 08:10

Pull request was closed

@wangrunji0408 wangrunji0408 merged commit 4790729 into release-1.7 Apr 1, 2024
24 of 25 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/bump-madsim-rdkafka-1.7 branch April 1, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants