feat(lints): lint on formatting Report in anyhow construction

[BugenZhao]

Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Inspired by #15109:

format_error lint should not be simply workarounded by adding an .as_report() method call. For example, we've started to instruct developers to use anyhow::Context if they're formatting errors in an anyhow! macro call since #14957.

This PR further enforce this by also adding the lints on the Reports in anyhow! calls. The UI test clearly shows the changes:

risingwave/lints/ui/format_error.stderr

Lines 347 to 378 in 294b520

	error: should not format error directly
	--> $DIR/format_error.rs:79:27
	|
	LL | let _ = anyhow!("{}", err.as_report());
	| ^^^^^^^^^^^^^^^
	|
	= help: consider directly wrapping the error with `anyhow::anyhow!(..)` instead of formatting its report
	error: should not format error directly
	--> $DIR/format_error.rs:80:48
	|
	LL | let _ = anyhow!("some error occurred: {}", err.as_report());
	| ^^^^^^^^^^^^^^^
	|
	= help: consider using `anyhow::Context::(with_)context` to attach additional message to the error and make it an error source instead
	error: should not format error directly
	--> $DIR/format_error.rs:81:29
	|
	LL | let _ = anyhow!("{:?}", anyhow_err.as_report());
	| ^^^^^^^^^^^^^^^^^^^^^^
	|
	= help: consider directly wrapping the error with `anyhow::anyhow!(..)` instead of formatting its report
	error: should not format error directly
	--> $DIR/format_error.rs:82:50
	|
	LL | let _ = anyhow!("some error occurred: {:?}", anyhow_err.as_report());
	| ^^^^^^^^^^^^^^^^^^^^^^
	|
	= help: consider using `anyhow::Context::(with_)context` to attach additional message to the error and make it an error source instead

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[xxchan]

try {??} looks strange

[xxchan]

magical

[wenym1]

LGTM!