fix: parsing the header of confluent protobuf message incorrectly #15444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rossil2012
requested review from
xiangjinwu and
tabVersion
and removed request for
xiangjinwu
tabVersion
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
LGTM
share the same impl with confluent https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java#L159
xiangjinwu
reviewed
Mar 5, 2024
Comment on lines
1177
to
1183
| let buffer = vec![0xFF, 0xFF, 0xFF, 0xFF, 0x0F]; | ||
| let (value, len) = decode_variant_zigzag(&buffer).unwrap(); | ||
| assert_eq!(value, i32::MIN); | ||
| assert_eq!(len, 5); | ||
|
|
||
| // 7. Invalid input (more than 5 bytes) | ||
| let buffer = vec![0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF]; |
There was a problem hiding this comment.
What if input is [0xFF, 0xFF, 0xFF, 0xFF, 0x7F]? It is within 5 encoded bytes but more than 32 bits after decoding.
There was a problem hiding this comment.
The result is i32::MIN, and the overflowed bits will be ignored. The behavior is the same as confluent's implementation.
There was a problem hiding this comment.
You can test the original impl here.
https://www.sololearn.com/en/compiler-playground/ccEr3Q77KgqB
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Resolve #14773.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.