Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): change the number of tasks generated by batch read to half of batch_parallelism #15416

Closed
wants to merge 4 commits into from

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Mar 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wcy-fdu wcy-fdu enabled auto-merge March 4, 2024 10:28
@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Mar 4, 2024

This change will make end to end source test timeout, specifically Extract data from kafka will spend take 3 minutes before the change, and 14 minutes after the change.
image
Uploading image.png…

Do you think this is acceptable? Or we only apply this change for the new file source batch reading?
cc @tabVersion @chenzl25

@tabVersion
Copy link
Contributor

does it make sense we load so much data in CI? cc @lmatz

@chenzl25
Copy link
Contributor

chenzl25 commented Mar 5, 2024

I think we can just keep it unchanged. Or only apply this change to the file source.

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Mar 5, 2024

I think we can just keep it unchanged. Or only apply this change to the file source.

After some offline discussion, we(@st1page @tabVersion) feel that there is no need to differentiate between Kafka or file source batch read here. Instead, we can use a magic number (currently set to 32) as the minimum value for the number of tasks, that is to set task parallelism = max(batch_parallelism / 2), 32.

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Mar 6, 2024

merged into #15358

@wcy-fdu wcy-fdu closed this Mar 6, 2024
auto-merge was automatically disabled March 6, 2024 07:12

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants