Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix compile err in release build of risectl #15412

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Mar 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled.

The compile error is introduced in #15365. Previously we use cargo build --bin risectl to build risectl without specifying the crate via -p risingwave_cmd, which makes cargo use the union of features used in all crates in the workspace. risingwave_simulation enables enable_test_epoch in its dependency list rather than in the dev dependency, which makes the feature union includes the enable_test_epoch by accidence. In this PR, by specifying the crate via -p risingwave_cmd, the feature enabled in risingwave_simulation will not be included in the future union, and then the enable_test_epoch will not be enabled when building risectl.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 requested review from hzxa21, huangjw806 and wcy-fdu March 4, 2024 08:33
@github-actions github-actions bot added the type/fix Bug fix label Mar 4, 2024
Copy link
Contributor

@huangjw806 huangjw806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huangjw806 huangjw806 added this pull request to the merge queue Mar 4, 2024
@huangjw806 huangjw806 removed this pull request from the merge queue due to a manual request Mar 4, 2024
@wenym1 wenym1 added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit bba2374 Mar 4, 2024
26 of 27 checks passed
@wenym1 wenym1 deleted the yiming/fix-test-epoch-release branch March 4, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants