fix: fix compile err in release build of risectl #15412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As titled.
The compile error is introduced in #15365. Previously we use
cargo build --bin risectl
to build risectl without specifying the crate via-p risingwave_cmd
, which makes cargo use the union of features used in all crates in the workspace.risingwave_simulation
enablesenable_test_epoch
in its dependency list rather than in the dev dependency, which makes the feature union includes theenable_test_epoch
by accidence. In this PR, by specifying the crate via-p risingwave_cmd
, the feature enabled inrisingwave_simulation
will not be included in the future union, and then theenable_test_epoch
will not be enabled when buildingrisectl
.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.