Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdc-connector): allow empty passwords #15411

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Mar 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Allow passwords to be empty for CDC connectors. Tested with my local PostgresQL instance.

Before:

dev=> CREATE SOURCE pg_mydb WITH (
    connector = 'postgres-cdc',
    hostname = '127.0.0.1',
    port = '5432',
    username = 'eric',
    password = '',
    database.name = 'test',
    slot.name = 'rw_slot'
);
ERROR:  Failed to run the query

Caused by these errors (recent errors listed first):
  1: gRPC request to meta service failed: Internal error
  2: failed to create source worker
  3: failed to create SplitEnumerator
  4: source cannot pass validation
  5: INVALID_ARGUMENT: 'password' not found, please check the WITH properties

After:

dev=> CREATE SOURCE pg_mydb WITH (
    connector = 'postgres-cdc',
    hostname = '127.0.0.1',
    port = '5432',
    username = 'eric',
    password = '',
    database.name = 'test',
    slot.name = 'rw_slot'
);
CREATE_SOURCE

dev=> CREATE TABLE t1 (
    k bigint,
    v varchar,
    PRIMARY KEY(k)
) FROM pg_mydb TABLE 'public.t1';
CREATE_TABLE

dev=> select * from t1;
 k |  v
---+-----
 1 | foo
(1 row)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh fuyufjh requested a review from StrikeW March 4, 2024 08:30
@github-actions github-actions bot added the type/fix Bug fix label Mar 4, 2024
Copy link
Contributor

@StrikeW StrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr.

@fuyufjh fuyufjh added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 9f527ac Mar 4, 2024
26 of 27 checks passed
@fuyufjh fuyufjh deleted the eric/cdc_source_allow_empty_password branch March 4, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants