Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdc): fix privilege check for shared mysql source #15395

Merged
merged 9 commits into from
Mar 11, 2024

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Mar 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Remove check for RELOAD and SHOW DATABASES for shared mysql source
  • Refactor the privilege check for mysql

The GetEventStreamRequest and ValidateSourceRequest are only used in memory, so changes to their proto would not cause breaking changes.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@StrikeW StrikeW changed the title fix(cdc): fix privilege check for shared mysql source fix(cdc): fix privilege check for shared mysql source (WIP) Mar 4, 2024
@StrikeW StrikeW force-pushed the siyuan/1.7-fix-mysql-privilege branch from ddc0674 to 35b8bba Compare March 4, 2024 08:11
@StrikeW StrikeW force-pushed the siyuan/1.7-fix-mysql-privilege branch from 35b8bba to 08c235a Compare March 4, 2024 08:31
@StrikeW StrikeW changed the title fix(cdc): fix privilege check for shared mysql source (WIP) fix(cdc): fix privilege check for shared mysql source Mar 11, 2024
@StrikeW StrikeW added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit bfd2206 Mar 11, 2024
31 of 33 checks passed
@StrikeW StrikeW deleted the siyuan/1.7-fix-mysql-privilege branch March 11, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants