Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: support protobuf for nats source #15378

Merged
merged 1 commit into from
Mar 1, 2024
Merged

test: support protobuf for nats source #15378

merged 1 commit into from
Mar 1, 2024

Conversation

neverchanje
Copy link
Contributor

@neverchanje neverchanje commented Mar 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add format::Protobuf to NATS source. Will resolve #15377

Checklist

I manually tested this feature. Will enable the protobuf integration testing later.

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the component/test Test related issue. label Mar 1, 2024
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general LGTM

@neverchanje neverchanje added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit 672ab0e Mar 1, 2024
31 checks passed
@neverchanje neverchanje deleted the wt-nats branch March 1, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support parsing Protobuf data from a NATS source.
2 participants