fix(connector): better locating and error reporting for connector library #15342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This acts as a preparation step of risingwavelabs/homebrew-risingwave#28.
Canonicalize the path of
current_exe
before looking for the siblinglibs
directory. So it's based on the real path of the binary (like/opt/homebrew/Cellar/risingwave/1.6/bin/risingwave
), instead of the symbolic link (/opt/homebrew/bin/risingwave
).opt/homebrew/bin/libs
will make no sense.Use
fs_err
as the replacement ofstd::fs
to provide better error reporting.Use
LazyLock::get_or_try_init
instead of storing theErr
variant into the static variable once the initialization fails. The main motivation is to resolve the error source issue, but the advised behavior appears to make more sense to me as well.risingwave/src/jni_core/src/jvm_runtime.rs
Lines 45 to 47 in d616c1c
Preview of the UI:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.