Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(udf): support always_retry_on_network_error config for udf functions (#15163) #15303

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

kwannoel
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

cherry pick #15163

Closes #15295

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel requested a review from a team as a code owner February 27, 2024 12:24
Copy link

gitguardian bot commented Feb 27, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@kwannoel kwannoel changed the base branch from main to release-1.7 February 27, 2024 12:24
@kwannoel
Copy link
Contributor Author

Need help to approve the cherry-pick, can't self-approve it

@lmatz lmatz enabled auto-merge (squash) February 27, 2024 12:48
@lmatz lmatz disabled auto-merge February 27, 2024 14:13
@lmatz lmatz merged commit 336db6b into release-1.7 Feb 27, 2024
22 of 25 checks passed
@lmatz lmatz deleted the kwannoel/c branch February 27, 2024 14:13
@lmatz
Copy link
Contributor

lmatz commented Feb 27, 2024

I forcefully merged it as I think it ran into the same stuck bug as described in #15296, correct me if I am wrong

@kwannoel
Copy link
Contributor Author

I forcefully merged it as I think it ran into the same stuck bug as described in #15296, correct me if I am wrong

Yes, this PR only change UDF, which should have nothing to do with recovery tests (they aren't tested there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cherrypick feat(udf): support config for udf functions (#15163) to branch release-1.7
3 participants