Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add await tree for opendal object store #15259

Closed
wants to merge 4 commits into from

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Feb 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wcy-fdu wcy-fdu requested a review from a team as a code owner February 26, 2024 08:35
@BugenZhao
Copy link
Member

Interesting. Can you elaborate more? What extra info does it provide additional to the spans we attached in MonitoredObjectStore?

.verbose_instrument_await("object_store_upload")

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Feb 26, 2024

Interesting. Can you elaborate more? What extra info does it provide additional to the spans we attached in MonitoredObjectStore?

.verbose_instrument_await("object_store_upload")

Recently we are debugging #15209, and found that the await tree of compactor node is a bit less:

--- Compactor Traces ---
>> Compaction Task 50708-0
Compaction Task 50708 Split 0  [1843.496s]
  compact [!!! 1843.496s]
    compact_and_build_sst [!!! 1843.496s]
      rewind [!!! 1843.496s]
        object_store_streaming_read_read_bytes [!!! 1843.456s]

>> Compaction Task 51832-0
Compaction Task 51832 Split 0  [1062.498s]
  compact [!!! 1062.498s]
    compact_and_build_sst [!!! 1062.498s]
      add_full_key [!!! 1061.768s]
        object_store_streaming_upload_write_bytes [!!! 1061.768s]

and OpenDAL provide AwaitTreeLayer, which will show the interfaces in it's operator level. With this await tree layer enabled, we will get these info right behind RisingWave's own trace file.

The bug is fixed, but it's still worth adding it and not complicated.

@wcy-fdu wcy-fdu requested review from hzxa21, Li0k and zwang28 February 26, 2024 14:15
@zwang28
Copy link
Contributor

zwang28 commented Feb 27, 2024

and OpenDAL provide AwaitTreeLayer, which will show the interfaces in it's operator level. With this await tree layer enabled, we will get these info right behind RisingWave's own trace file.

Can you give an example file of OpenDAL's await tree, collected from RisingWave?

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you think it needs to run a benchmark before merging?

@fuyufjh fuyufjh changed the title chore: add await tree for opendal object store feat: add await tree for opendal object store Feb 28, 2024
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, testing to get await-tree file before merge

Copy link
Contributor

This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Close this PR as there's no further actions taken after it is marked as stale for 7 days. Sorry! 🙏

You can reopen it when you have time to continue working on it.

@github-actions github-actions bot closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants