-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add await tree for opendal object store #15259
Conversation
Interesting. Can you elaborate more? What extra info does it provide additional to the spans we attached in risingwave/src/object_store/src/object/mod.rs Line 584 in 468f7ec
|
Recently we are debugging #15209, and found that the await tree of compactor node is a bit less:
and OpenDAL provide AwaitTreeLayer, which will show the interfaces in it's operator level. With this await tree layer enabled, we will get these info right behind RisingWave's own trace file. The bug is fixed, but it's still worth adding it and not complicated. |
…risingwavelabs/risingwave into wcy/open_await_tree_for_opendal
Can you give an example file of OpenDAL's await tree, collected from RisingWave? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do you think it needs to run a benchmark before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, testing to get await-tree file before merge
This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review. |
Close this PR as there's no further actions taken after it is marked as stale for 7 days. Sorry! 🙏 You can reopen it when you have time to continue working on it. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.