Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expr): align timestamp(tz)'s output format with pg's #15053

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

KeXiangWang
Copy link
Contributor

@KeXiangWang KeXiangWang commented Feb 7, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Before:

SELECT make_timestamp(-1973, 07, 15, 08, 15, 55.33);
----
-1972-07-15 08:15:55.330

After this PR:

SELECT make_timestamp(-1973, 07, 15, 08, 15, 55.33);
----
1973-07-15 08:15:55.330 BC

Followup for #14827 (comment)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@KeXiangWang KeXiangWang requested a review from a team as a code owner February 7, 2024 20:17
@github-actions github-actions bot added the type/fix Bug fix label Feb 7, 2024
@KeXiangWang KeXiangWang force-pushed the wkx/fix-timestamp-to_text branch from b639b35 to ee921d0 Compare February 7, 2024 20:18
@KeXiangWang KeXiangWang added ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. and removed breaking-change labels Feb 7, 2024
src/common/src/types/datetime.rs Outdated Show resolved Hide resolved
src/common/src/types/timestamptz.rs Outdated Show resolved Hide resolved
@KeXiangWang KeXiangWang force-pushed the wkx/fix-timestamp-to_text branch from ee921d0 to dbd954a Compare February 20, 2024 01:06
@KeXiangWang KeXiangWang requested a review from stdrc February 20, 2024 01:07
@KeXiangWang KeXiangWang added this pull request to the merge queue Feb 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2024
@KeXiangWang KeXiangWang added this pull request to the merge queue Feb 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2024
@KeXiangWang KeXiangWang force-pushed the wkx/fix-timestamp-to_text branch from dbd954a to 36630f4 Compare February 20, 2024 06:33
@KeXiangWang KeXiangWang force-pushed the wkx/fix-timestamp-to_text branch from 8130555 to ca31707 Compare February 20, 2024 19:47
Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiangjinwu xiangjinwu added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit fb6dbe2 Feb 23, 2024
29 checks passed
@xiangjinwu xiangjinwu deleted the wkx/fix-timestamp-to_text branch February 23, 2024 08:02
xiangjinwu pushed a commit that referenced this pull request Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants