-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(expr): align timestamp(tz)'s output format with pg's #15053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeXiangWang
force-pushed
the
wkx/fix-timestamp-to_text
branch
from
February 7, 2024 20:18
b639b35
to
ee921d0
Compare
KeXiangWang
added
ci/run-backwards-compat-tests
Run backwards compatibility tests in your PR.
and removed
breaking-change
labels
Feb 7, 2024
stdrc
reviewed
Feb 18, 2024
KeXiangWang
force-pushed
the
wkx/fix-timestamp-to_text
branch
from
February 20, 2024 01:06
ee921d0
to
dbd954a
Compare
xiangjinwu
approved these changes
Feb 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 20, 2024
KeXiangWang
force-pushed
the
wkx/fix-timestamp-to_text
branch
from
February 20, 2024 06:33
dbd954a
to
36630f4
Compare
KeXiangWang
force-pushed
the
wkx/fix-timestamp-to_text
branch
from
February 20, 2024 19:47
8130555
to
ca31707
Compare
stdrc
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BugenZhao
approved these changes
Feb 22, 2024
xiangjinwu
pushed a commit
that referenced
this pull request
Feb 24, 2024
…5221) Co-authored-by: Kexiang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
ci/run-backwards-compat-tests
Run backwards compatibility tests in your PR.
type/fix
Bug fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Before:
After this PR:
Followup for #14827 (comment)
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.