feat(test): enable udf in nexmark q14 #14975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Runji Wang <[email protected]>
lmatz
approved these changes
Feb 4, 2024
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
wangrunji0408
force-pushed
the
wrj/nexmark-q14-udf
branch
from
f4cb852 to
2088cd5
Compare
Signed-off-by: Runji Wang <[email protected]>
wangrunji0408
force-pushed
the
wrj/nexmark-q14-udf
branch
from
2088cd5 to
e134da7
Compare
Signed-off-by: Runji Wang <[email protected]>
BugenZhao
reviewed
Feb 5, 2024
| @@ -1,6 +1,11 @@ | |||
| use arrow_udf::function; | |||
| use rust_decimal::Decimal; | |||
|
|
|||
| #[function("count_char(varchar, varchar) -> int")] | |||
| fn count_char(s: &str, c: &str) -> i32 { | |||
There was a problem hiding this comment.
No. I just added it here in case of future use.
BugenZhao
approved these changes
Feb 5, 2024
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
wangrunji0408
force-pushed
the
wrj/nexmark-q14-udf
branch
from
667f68e to
0eec285
Compare
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
resolve #14857 and fix #14991
Add
count_charback to nexmark q14 using JavaScript UDF.Checklist
./risedev check(or alias,./risedev c)Documentation