Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): assert no read version in storage reset #14876

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Jan 30, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

We should ensure that all actors have been dropped when calling clear_shared_buffer, and when all actors have been dropped, there should not be any remaining read version in the read version map.

May early panic at the error of #14858.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 requested a review from hzxa21 January 30, 2024 11:15
@github-actions github-actions bot added the type/fix Bug fix label Jan 30, 2024
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenym1 wenym1 enabled auto-merge January 31, 2024 07:21
@wenym1 wenym1 disabled auto-merge January 31, 2024 07:23
@wenym1 wenym1 enabled auto-merge January 31, 2024 09:36
@wenym1 wenym1 disabled auto-merge January 31, 2024 09:42
@wenym1 wenym1 added this pull request to the merge queue Feb 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 1, 2024
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@wenym1 wenym1 changed the title fix(storage): assert no read version in reset fix(storage): assert no read version in storage reset Feb 1, 2024
@wenym1 wenym1 added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 5d43604 Feb 1, 2024
28 of 29 checks passed
@wenym1 wenym1 deleted the yiming/no-read-version-in-reset branch February 1, 2024 08:33
kwannoel added a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants