Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(udf-context): assemble sql udf related functions inside UdfContext #14732

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

xzhseh
Copy link
Contributor

@xzhseh xzhseh commented Jan 22, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled, move extract_udf_expression & create_udf_context inside UdfContext.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xzhseh xzhseh self-assigned this Jan 22, 2024
@xzhseh xzhseh changed the title refactor(udf-context): assemble sql udf related functions inside UdfC… refactor(udf-context): assemble sql udf related functions inside UdfContext Jan 22, 2024
@xzhseh xzhseh changed the title refactor(udf-context): assemble sql udf related functions inside UdfContext refactor(udf-context): assemble sql udf related functions inside UdfContext Jan 22, 2024
Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit 2fd1c9a Jan 23, 2024
35 of 36 checks passed
@wangrunji0408 wangrunji0408 deleted the xzhseh/refactor-udf-context branch January 23, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants