-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(source): embed protobuf well known types when using schema registry #13370
feat(source): embed protobuf well known types when using schema registry #13370
Conversation
756b158
to
b3ce125
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -98,6 +98,10 @@ RUST_LOG="info,risingwave_stream=info,risingwave_batch=info,risingwave_storage=i | |||
cargo make ci-start ci-1cn-1fe | |||
python3 -m pip install requests protobuf confluent-kafka | |||
python3 e2e_test/schema_registry/pb.py "message_queue:29092" "http://message_queue:8081" "sr_pb_test" 20 | |||
echo "make sure google/protobuf/source_context.proto is NOT in schema registry" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really a good practice!
It only contains generated rust code, rather than the raw proto source required by |
b3ce125
to
48bad7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## main #13370 +/- ##
==========================================
+ Coverage 67.79% 67.86% +0.06%
==========================================
Files 1526 1526
Lines 259801 259812 +11
==========================================
+ Hits 176145 176330 +185
+ Misses 83656 83482 -174
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
These 12 proto source files containing well known types shall be bundled together with protoc / libprotobuf as they may not be available from schema registry.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
Protobuf well known types can now be used without including them in schema registry.