Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): set kafka consumer group id in config #13223

Closed
wants to merge 1 commit into from

Conversation

yufansong
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Currently we forget to use properties.group.id this filed. We will auto generate a new for consumer according this line

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yufansong yufansong requested a review from tabVersion November 2, 2023 22:28
@yufansong yufansong changed the title Fix(connector): fix kafka consumer group id fix(connector): fix kafka consumer group id Nov 2, 2023
@github-actions github-actions bot added type/fix Bug fix and removed Invalid PR Title labels Nov 2, 2023
@yufansong yufansong changed the title fix(connector): fix kafka consumer group id fix: set kafka consumer group id in config Nov 2, 2023
@yufansong yufansong removed the type/fix Bug fix label Nov 2, 2023
@github-actions github-actions bot added the type/fix Bug fix label Nov 2, 2023
@yufansong yufansong changed the title fix: set kafka consumer group id in config fix(connector): set kafka consumer group id in config Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #13223 (89f6af1) into main (8b58861) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #13223      +/-   ##
==========================================
- Coverage   68.13%   68.12%   -0.02%     
==========================================
  Files        1515     1515              
  Lines      257111   257113       +2     
==========================================
- Hits       175191   175155      -36     
- Misses      81920    81958      +38     
Flag Coverage Δ
rust 68.12% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/connector/src/source/kafka/source/reader.rs 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tabVersion
Copy link
Contributor

we always generate group.id by design.
RW use the low-level consumer API to consume each partition in each executor. Using kafka consumer group here will lead to consumption progress inconsistency between local state table and kafka broker.

@yufansong
Copy link
Member Author

Discussed offline. This behaviour is expected. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants