-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): implement OAuth authentication #13151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's keep this PR and wait for the progress on the cloud side later.
This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review. |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9425213 | Triggered | Generic Password | 169720c | ci/scripts/e2e-source-test.sh | View secret |
9425213 | Triggered | Generic Password | 169720c | ci/scripts/e2e-source-test.sh | View secret |
9425213 | Triggered | Generic Password | 169720c | ci/scripts/regress-test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job! Have you tested it with @xuhui-lu ?
Hi @Rossil2012 , I resolved all comments and pushed some commits directly in this PR. Please help to verify if on your local setup. Let's merge it and cherry-pick to release 1.7 if it works. |
Wow, thank you! However, in order to support per-user oauth configuration, @xuhui-lu and I determined to add a new syntax like |
So IIUC the current implementation is not considered as a stable or final one, right? Is that so urgent that this should be released in 1.7? I would suggest to wait for 1.8 which IIRC will be frozen in recent days. |
This feature may be urgent for cloud, cc @xuhui-lu. |
This is related to a page revamp recently proposed by yingjun. We need this feature to remove the password for accessing cloud web console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve on behalf of Cargo-lock
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Refer to #11440.
Support to authenticate with OAuth token acquired from cloud.
The basic workflow can be tested as follows:
kid
andalg
are required in the header of JWT, andkid
is also required in the JWKs returned by the JWKS server. All params set in user creation (except jwks_url) will be checked in the claims of jwt, any mismatch will deny the login process.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
New sql syntax:
Note that key in the options must be SMALL-CASED.