fix(cdc): ensure connector is inited after the CREATE TABLE is finished #13130
Conversation
|
Will this be somehow related to #12476? |
Didn't look into this issue yet, will do later. |
StrikeW
changed the title
StrikeW
changed the title
StrikeW
changed the title
StrikeW
force-pushed
the
siyuan/init-connector-in-source
branch
from
7e108da to
eff2edd
Compare
StrikeW
force-pushed
the
siyuan/init-connector-in-source
branch
from
eff2edd to
cf0b662
Compare
StrikeW
force-pushed
the
siyuan/init-connector-in-source
branch
from
cf0b662 to
b6bc630
Compare
StrikeW
force-pushed
the
siyuan/init-connector-in-source
branch
from
b6bc630 to
777557d
Compare
Codecov Report
@@ Coverage Diff @@
## main #13130 +/- ##
==========================================
+ Coverage 68.10% 68.14% +0.04%
==========================================
Files 1507 1507
Lines 255634 255674 +40
==========================================
+ Hits 174104 174237 +133
+ Misses 81530 81437 -93
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| ) | ||
| .await | ||
| } | ||
| create_split_reader(*props, splits, parser_config, source_ctx, data_gen_columns) |
There was a problem hiding this comment.
no await here? I thought it is about to wait till recv handshake resp from embedded dbz
There was a problem hiding this comment.
We has await on the outer try_join_all
| // In RisingWave we assume the upstream changelog may contain duplicate events and | ||
| // handle conflicts in the mview operator, thus we don't need to obey the above | ||
| // instructions. So we decrease the wait time here to reclaim jvm thread faster. | ||
| .option("-Ddebezium.embedded.shutdown.pause.before.interrupt.ms=1"); |
There was a problem hiding this comment.
btw can you share more about the param?
There was a problem hiding this comment.
It is a timeout config to forcefully stop the engine thread.
https://github.com/debezium/debezium/blob/e67620d30ee12ce2c257b2fad2eca4259eaef0e6/debezium-embedded/src/main/java/io/debezium/embedded/EmbeddedEngine.java#L240-L247
…ed (#13130) (#13251) Co-authored-by: StrikeW <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
CREATE TABLE). Otherwise, the connector may start to run even after aDROP TABLEhas been executed and cause unexpected race condition happen on upstream DB.-Ddebezium.embedded.shutdown.pause.before.interrupt.msto embedded jvmFix the unstable citus-cdc integration test
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.