perf(connector): do not create span for parsing each row #13105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugenZhao
commented
Oct 27, 2023
| @@ -579,14 +583,14 @@ async fn into_chunk_stream<P: ByteStreamSourceParser>(mut parser: P, data_stream | |||
| match txn_ctl { | |||
| TransactionControl::Begin { id } => { | |||
| if let Some(Transaction { id: current_id, .. }) = ¤t_transaction { | |||
| tracing::warn!(parent: &parse_span, current_id, id, "already in transaction"); | |||
| tracing::warn!(current_id, id, "already in transaction"); | |||
There was a problem hiding this comment.
Transaction is only applicable to CDC source, where split_id and offset is not that useful. So simply omit them here.
Base automatically changed from
bz/connector-parser-nexmark-integration-bench
to
main
October 27, 2023 07:44
xxchan
approved these changes
Oct 27, 2023
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/do-not-create-span-for-parsing-each-row
branch
from
7bcf367 to
f667892
Compare
Codecov Report
@@ Coverage Diff @@
## main #13105 +/- ##
==========================================
+ Coverage 68.26% 68.34% +0.08%
==========================================
Files 1498 1498
Lines 252574 252584 +10
==========================================
+ Hits 172411 172621 +210
+ Misses 80163 79963 -200
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In #13073 and #12959 (comment), we find the performance overhead of constructing row-level tracing span is not acceptable. So we remove that in this PR, and manually pass the row context.
Benchmark shows that there's no cost for happy path, which is expected.
fix #12959
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.