Skip to content

Commit

Permalink
Merge branch 'main' into dylan/bump_icelake
Browse files Browse the repository at this point in the history
  • Loading branch information
chenzl25 authored Feb 28, 2024
2 parents 2f1ef7e + 495ed83 commit c0cbcaf
Show file tree
Hide file tree
Showing 31 changed files with 212 additions and 98 deletions.
2 changes: 1 addition & 1 deletion dashboard/components/CatalogModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import {
Relation,
relationIsStreamingJob,
relationTypeTitleCase,
} from "../pages/api/streaming"
} from "../lib/api/streaming"
import { ReactJson } from "./Relations"

export function useCatalogModal(relationList: Relation[] | undefined) {
Expand Down
2 changes: 1 addition & 1 deletion dashboard/components/RateBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

import { Box, Text, Tooltip } from "@chakra-ui/react"
import { tinycolor } from "@ctrl/tinycolor"
import { p50, p90, p95, p99 } from "../pages/api/metric"
import { p50, p90, p95, p99 } from "../lib/api/metric"
import { MetricsSample } from "./metrics"

export default function RateBar({ samples }: { samples: MetricsSample[] }) {
Expand Down
12 changes: 6 additions & 6 deletions dashboard/components/RelationDependencyGraph.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@
import { theme } from "@chakra-ui/react"
import * as d3 from "d3"
import { useCallback, useEffect, useRef } from "react"
import {
Relation,
relationIsStreamingJob,
relationType,
relationTypeTitleCase,
} from "../lib/api/streaming"
import {
Enter,
Position,
Expand All @@ -26,12 +32,6 @@ import {
flipLayoutRelation,
generateRelationEdges,
} from "../lib/layout"
import {
Relation,
relationIsStreamingJob,
relationType,
relationTypeTitleCase,
} from "../pages/api/streaming"
import { CatalogModal, useCatalogModal } from "./CatalogModal"

function boundBox(
Expand Down
4 changes: 2 additions & 2 deletions dashboard/components/Relations.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ import Head from "next/head"
import Link from "next/link"
import { Fragment } from "react"
import Title from "../components/Title"
import useFetch from "../lib/api/fetch"
import { Relation, StreamingJob } from "../lib/api/streaming"
import extractColumnInfo from "../lib/extractInfo"
import useFetch from "../pages/api/fetch"
import { Relation, StreamingJob } from "../pages/api/streaming"
import {
Sink as RwSink,
Source as RwSource,
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion dashboard/lib/layout.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
*/

import { max } from "lodash"
import { Relation } from "../pages/api/streaming"
import { TableFragments_Fragment } from "../proto/gen/meta"
import { GraphNode } from "./algo"
import { Relation } from "./api/streaming"

export type Enter<Type> = Type extends d3.Selection<
any,
Expand Down
6 changes: 3 additions & 3 deletions dashboard/pages/await_tree.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ import Head from "next/head"
import { Fragment, useEffect, useState } from "react"
import SpinnerOverlay from "../components/SpinnerOverlay"
import Title from "../components/Title"
import api from "../lib/api/api"
import { getClusterInfoComputeNode } from "../lib/api/cluster"
import useFetch from "../lib/api/fetch"
import { StackTraceResponse } from "../proto/gen/monitor_service"
import api from "./api/api"
import { getClusterInfoComputeNode } from "./api/cluster"
import useFetch from "./api/fetch"

const SIDEBAR_WIDTH = 200
const ALL_COMPUTE_NODES = ""
Expand Down
4 changes: 2 additions & 2 deletions dashboard/pages/cluster.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ import { Area, AreaChart, ResponsiveContainer, XAxis, YAxis } from "recharts"
import { Metrics, MetricsSample } from "../components/metrics"
import Title from "../components/Title"
import useErrorToast from "../hook/useErrorToast"
import { WorkerNode } from "../proto/gen/common"
import {
getClusterInfoComputeNode,
getClusterInfoFrontend,
getClusterMetrics,
} from "./api/cluster"
} from "../lib/api/cluster"
import { WorkerNode } from "../proto/gen/common"

function WorkerNodeComponent({
workerNodeType,
Expand Down
8 changes: 6 additions & 2 deletions dashboard/pages/dependency_graph.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,13 @@ import RelationDependencyGraph, {
nodeRadius,
} from "../components/RelationDependencyGraph"
import Title from "../components/Title"
import useFetch from "../lib/api/fetch"
import {
Relation,
getRelations,
relationIsStreamingJob,
} from "../lib/api/streaming"
import { RelationPoint } from "../lib/layout"
import useFetch from "./api/fetch"
import { Relation, getRelations, relationIsStreamingJob } from "./api/streaming"

const SIDEBAR_WIDTH = "200px"

Expand Down
12 changes: 6 additions & 6 deletions dashboard/pages/fragment_graph.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,7 @@ import FragmentDependencyGraph from "../components/FragmentDependencyGraph"
import FragmentGraph from "../components/FragmentGraph"
import Title from "../components/Title"
import useErrorToast from "../hook/useErrorToast"
import { FragmentBox } from "../lib/layout"
import { TableFragments, TableFragments_Fragment } from "../proto/gen/meta"
import { Dispatcher, MergeNode, StreamNode } from "../proto/gen/stream_plan"
import useFetch from "./api/fetch"
import useFetch from "../lib/api/fetch"
import {
BackPressureInfo,
BackPressuresMetrics,
Expand All @@ -52,8 +49,11 @@ import {
p90,
p95,
p99,
} from "./api/metric"
import { getFragments, getStreamingJobs } from "./api/streaming"
} from "../lib/api/metric"
import { getFragments, getStreamingJobs } from "../lib/api/streaming"
import { FragmentBox } from "../lib/layout"
import { TableFragments, TableFragments_Fragment } from "../proto/gen/meta"
import { Dispatcher, MergeNode, StreamNode } from "../proto/gen/stream_plan"

interface DispatcherNode {
[actorId: number]: Dispatcher[]
Expand Down
6 changes: 3 additions & 3 deletions dashboard/pages/heap_profiling.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ import path from "path"
import { Fragment, useEffect, useState } from "react"
import SpinnerOverlay from "../components/SpinnerOverlay"
import Title from "../components/Title"
import api from "../lib/api/api"
import { getClusterInfoComputeNode } from "../lib/api/cluster"
import useFetch from "../lib/api/fetch"
import { WorkerNode } from "../proto/gen/common"
import { ListHeapProfilingResponse } from "../proto/gen/monitor_service"
import api from "./api/api"
import { getClusterInfoComputeNode } from "./api/cluster"
import useFetch from "./api/fetch"

const SIDEBAR_WIDTH = 200

Expand Down
2 changes: 1 addition & 1 deletion dashboard/pages/indexes.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
Relations,
streamingJobColumns,
} from "../components/Relations"
import { getIndexes } from "./api/streaming"
import { getIndexes } from "../lib/api/streaming"

export default function Indexes() {
return Relations("Indexes", getIndexes, [
Expand Down
2 changes: 1 addition & 1 deletion dashboard/pages/internal_tables.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*/

import { primaryKeyColumn, Relations } from "../components/Relations"
import { getInternalTables } from "./api/streaming"
import { getInternalTables } from "../lib/api/streaming"

export default function InternalTables() {
return Relations("Internal Tables", getInternalTables, [primaryKeyColumn])
Expand Down
2 changes: 1 addition & 1 deletion dashboard/pages/materialized_views.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
Relations,
streamingJobColumns,
} from "../components/Relations"
import { getMaterializedViews } from "./api/streaming"
import { getMaterializedViews } from "../lib/api/streaming"

export default function MaterializedViews() {
return Relations("Materialized Views", getMaterializedViews, [
Expand Down
2 changes: 1 addition & 1 deletion dashboard/pages/settings.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import {
API_ENDPOINT_KEY,
DEFAULT_API_ENDPOINT,
PREDEFINED_API_ENDPOINTS,
} from "./api/api"
} from "../lib/api/api"

export default function Settings() {
const isClient = useIsClient()
Expand Down
2 changes: 1 addition & 1 deletion dashboard/pages/sinks.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
Relations,
streamingJobColumns,
} from "../components/Relations"
import { getSinks } from "./api/streaming"
import { getSinks } from "../lib/api/streaming"

export default function Sinks() {
return Relations("Sinks", getSinks, [
Expand Down
2 changes: 1 addition & 1 deletion dashboard/pages/sources.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ import {
dependentsColumn,
Relations,
} from "../components/Relations"
import { getSources } from "../lib/api/streaming"
import { Source } from "../proto/gen/catalog"
import { getSources } from "./api/streaming"

export default function DataSources() {
const rowFormatColumn: Column<Source> = {
Expand Down
2 changes: 1 addition & 1 deletion dashboard/pages/tables.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ import {
Relations,
streamingJobColumns,
} from "../components/Relations"
import { getTables } from "../lib/api/streaming"
import { Table } from "../proto/gen/catalog"
import { getTables } from "./api/streaming"

export default function Tables() {
const associatedSourceColumn: Column<Table> = {
Expand Down
2 changes: 1 addition & 1 deletion dashboard/pages/views.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*/

import { Relations } from "../components/Relations"
import { getViews } from "./api/streaming"
import { getViews } from "../lib/api/streaming"

export default function Views() {
return Relations("Views", getViews, [])
Expand Down
46 changes: 46 additions & 0 deletions e2e_test/batch/catalog/atlasgo.slt.part
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,52 @@ ORDER BY
n.nspname, e.enumtypid, e.enumsortorder
----

query T rowsort
SELECT
(
SELECT
t.typtype
FROM
pg_catalog.pg_type AS t
WHERE
t.oid = t4.typelem
) AS elemtyp
FROM
pg_catalog.pg_type AS t4;
----
NULL
NULL
NULL
NULL
NULL
NULL
NULL
NULL
NULL
NULL
NULL
NULL
NULL
NULL
NULL
NULL
NULL
b
b
b
b
b
b
b
b
b
b
b
b
b
b
b

query TTTTTTTTTTTTTTTTTTTTTT
SELECT
t1.table_name,
Expand Down
14 changes: 14 additions & 0 deletions src/frontend/planner_test/tests/testdata/input/atlasgo.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
- sql: |
SELECT
(
SELECT
t.typtype
FROM
pg_catalog.pg_type AS t
WHERE
t.oid = t4.typelem
) AS elemtyp
FROM
pg_catalog.pg_type AS t4;
expected_outputs:
- batch_plan
21 changes: 21 additions & 0 deletions src/frontend/planner_test/tests/testdata/output/atlasgo.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# This file is automatically generated. See `src/frontend/planner_test/README.md` for more information.
- sql: |
SELECT
(
SELECT
t.typtype
FROM
pg_catalog.pg_type AS t
WHERE
t.oid = t4.typelem
) AS elemtyp
FROM
pg_catalog.pg_type AS t4;
batch_plan: |-
BatchExchange { order: [], dist: Single }
└─BatchHashJoin { type: LeftOuter, predicate: pg_type.typelem = pg_type.oid, output: [pg_type.typtype] }
├─BatchExchange { order: [], dist: HashShard(pg_type.typelem) }
│ └─BatchScan { table: pg_type, columns: [pg_type.typelem], distribution: Single }
└─BatchExchange { order: [], dist: HashShard(pg_type.oid) }
└─BatchProject { exprs: [pg_type.typtype, pg_type.oid] }
└─BatchScan { table: pg_type, columns: [pg_type.oid, pg_type.typtype], distribution: Single }
Loading

0 comments on commit c0cbcaf

Please sign in to comment.