Skip to content

Commit

Permalink
remove test
Browse files Browse the repository at this point in the history
  • Loading branch information
KeXiangWang committed Feb 26, 2024
1 parent 20a84f8 commit b30d061
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 15 deletions.
12 changes: 0 additions & 12 deletions e2e_test/error_ui/simple/main.slt
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,6 @@ Caused by:
Near "selet"


statement error
create function int_42() returns int as int_42 using link 'localhost:8815';
----
db error: ERROR: Failed to run the query

Caused by these errors (recent errors listed first):
1: failed to connect to UDF service
2: transport error
3: error trying to connect
4: invalid URL, scheme is missing


statement error
alter system set not_exist_key to value;
----
Expand Down
8 changes: 5 additions & 3 deletions src/expr/udf/src/external.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@ impl ArrowFlightUdfClient {
if addr.starts_with("https://") {
addr = addr.strip_prefix("https://").unwrap();
}
let host_addr = HostAddr::from_str(addr)
.map_err(|e| Error::service_error(format!("invalid address: {}, err: {}", addr, e)))?;
let host_addr = HostAddr::from_str(addr).map_err(|e| {
Error::service_error(format!("invalid address: {}, err: {}", addr, e.as_report()))
})?;
let channel = LoadBalancedChannel::builder((host_addr.host.clone(), host_addr.port))
.dns_probe_interval(std::time::Duration::from_secs(DNS_PROBE_INTERVAL_SECS))
.timeout(Duration::from_secs(REQUEST_TIMEOUT_SECS))
Expand All @@ -88,7 +89,8 @@ impl ArrowFlightUdfClient {
.map_err(|e| {
Error::service_error(format!(
"failed to create LoadBalancedChannel, address: {}, err: {}",
host_addr, e
host_addr,
e.as_report()
))
})?;
let client = FlightServiceClient::new(channel.into());
Expand Down

0 comments on commit b30d061

Please sign in to comment.