Skip to content

Commit

Permalink
reset control stream on sync error
Browse files Browse the repository at this point in the history
  • Loading branch information
wenym1 committed Dec 11, 2024
1 parent 2a52ec7 commit 2fce29a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/stream/src/task/barrier_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,10 @@ impl LocalBarrierWorker {
self.on_epoch_completed(database_id, partial_graph_id, barrier.epoch.prev, result);
}
Err(err) => {
self.on_database_failure(database_id, None, err, "failed to complete epoch");
// TODO: may only report as database failure instead of reset the stream
// when the HummockUploader support partial recovery. Currently the HummockUploader
// enter `Err` state and stop working until a global recovery to clear the uploader.
self.control_stream_handle.reset_stream_with_err(Status::internal(format!("failed to complete epoch: {} {} {:?} {:?}", database_id, partial_graph_id.0, barrier.epoch, err.as_report())));
}
}
},
Expand Down

0 comments on commit 2fce29a

Please sign in to comment.