Skip to content

Commit

Permalink
fix: enable compaction output check regardless of the ReportTask rpc …
Browse files Browse the repository at this point in the history
…status (#14840)
  • Loading branch information
hzxa21 authored Jan 29, 2024
1 parent e3e109a commit 1a22e82
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions src/storage/src/hummock/compactor/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -502,18 +502,17 @@ pub fn start_compactor(
.as_millis() as u64,
}) {
tracing::warn!(error = %e.as_report(), "Failed to report task {task_id:?}");
if enable_check_compaction_result && need_check_task {
match check_compaction_result(&compact_task, context.clone()).await {
Err(e) => {
tracing::warn!(error = %e.as_report(), "Failed to check compaction task {}",compact_task.task_id);
},
Ok(true) => (),
Ok(false) => {
panic!("Failed to pass consistency check for result of compaction task:\n{:?}", compact_task_to_string(&compact_task));
}
}
if enable_check_compaction_result && need_check_task {
match check_compaction_result(&compact_task, context.clone()).await {
Err(e) => {
tracing::warn!(error = %e.as_report(), "Failed to check compaction task {}",compact_task.task_id);
},
Ok(true) => (),
Ok(false) => {
panic!("Failed to pass consistency check for result of compaction task:\n{:?}", compact_task_to_string(&compact_task));
}
}

}
}
ResponseEvent::VacuumTask(vacuum_task) => {
Expand Down

0 comments on commit 1a22e82

Please sign in to comment.