fix engine migration

src/common/src/catalog/mod.rs

@@ -542,7 +542,6 @@ impl ConflictBehavior {
 
 #[derive(Default, Debug, Clone, Copy, PartialEq, Eq, Hash)]
 pub enum Engine {
-    /// TODO(nimtable): use iceberg engine as default.
     #[default]
     Hummock,
     Iceberg,

src/frontend/src/handler/create_source.rs

@@ -1363,7 +1363,7 @@ pub async fn extract_iceberg_columns(
                 );
                 ColumnCatalog {
                     column_desc,
-                    // hide the _row_id column for nimtable
+                    // hide the _row_id column for iceberg engine table
                     // This column is auto generated when users define a table without primary key
                     is_hidden: field.name() == ROWID_PREFIX,
                 }

src/meta/model/migration/src/lib.rs

@@ -26,6 +26,8 @@ mod m20241016_065621_hummock_gc_history;
 mod m20241025_062548_singleton_vnode_count;
 mod m20241115_085007_remove_function_type;
 mod m20241120_182555_hummock_add_time_travel_sst_index;
+
+mod m20241121_101830_table_engine;
 mod utils;
 
 pub struct Migrator;
@@ -90,6 +92,7 @@ impl MigratorTrait for Migrator {
             Box::new(m20241025_062548_singleton_vnode_count::Migration),
             Box::new(m20241115_085007_remove_function_type::Migration),
             Box::new(m20241120_182555_hummock_add_time_travel_sst_index::Migration),
+            Box::new(m20241121_101830_table_engine::Migration),
         ]
     }
 }

src/meta/model/migration/src/m20241121_101830_table_engine.rs

@@ -0,0 +1,38 @@
+use sea_orm_migration::prelude::{Table as MigrationTable, *};
+
+#[derive(DeriveMigrationName)]
+pub struct Migration;
+
+#[async_trait::async_trait]
+impl MigrationTrait for Migration {
+    async fn up(&self, manager: &SchemaManager) -> Result<(), DbErr> {
+        // Replace the sample below with your own migration scripts
+        manager
+            .alter_table(
+                MigrationTable::alter()
+                    .table(Table::Table)
+                    .add_column(ColumnDef::new(Table::Engine).string().not_null())
+                    .to_owned(),
+            )
+            .await
+    }
+
+    async fn down(&self, manager: &SchemaManager) -> Result<(), DbErr> {
+        manager
+            .alter_table(
+                MigrationTable::alter()
+                    .table(Table::Table)
+                    .drop_column(Alias::new(Table::Engine.to_string()))
+                    .to_owned(),
+            )
+            .await?;
+        Ok(())
+    }
+}
+
+#[derive(DeriveIden)]
+
+enum Table {
+    Table,
+    Engine,
+}

src/sqlparser/src/ast/mod.rs

@@ -1891,7 +1891,6 @@ impl fmt::Display for Statement {
                     write!(f, " FROM {}", info.source_name)?;
                     write!(f, " TABLE '{}'", info.external_table_name)?;
                 }
-                // TODO(nimtable): change the default engine to iceberg
                 match engine {
                     Engine::Hummock => {},
                     Engine::Iceberg => {

src/sqlparser/src/parser.rs

@@ -2595,7 +2595,6 @@ impl Parser<'_> {
                 parser_err!("Unsupported engine: {}", engine_name);
             }
         } else {
-            // TODO(nimtable): default to hummock, later we can change it to iceberg
             Engine::Hummock
         };