Arc review comments #190
Open
Arc review comments #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avpatel @hschauhan @SiFiveHolland @clementleger @pathakraul @jones-drew : I will send the patches on the mailing list for wider review before merging. It is just easier to discuss via GH PR/issues for ARC review comments. |
atishp04
force-pushed
the
arc_review_comments
branch
from
f3de8de to
e989ab3
Compare
atishp04
added a commit
to atishp04/riscv-sbi-doc
that referenced
this pull request
Jan 3, 2025
The ARC committee has given the first set of feedbacks. The ongoing discussion can be found here[1]. This series address most of the feedback raised in the thread. Please review it at your convenience. The github PR for this series can be found at [2] [1] riscv-non-isa#188 [2] riscv-non-isa#190 Cc: [email protected] # Describe the purpose of this series. The information you put here # will be used by the project maintainer to make a decision whether # your patches should be reviewed, and in what priority order. Please be # very detailed and link to any relevant discussions or sites that the # maintainer can review to better understand your proposed changes. If you # only have a single patch in your series, the contents of the cover # letter will be appended to the "under-the-cut" portion of the patch. # Lines starting with # will be removed from the cover letter. You can # use them to add notes or reminders to yourself. If you want to use # markdown headers in your cover letter, start the line with ">#". # You can add trailers to the cover letter. Any email addresses found in # these trailers will be added to the addresses specified/generated # during the b4 send stage. You can also run "b4 prep --auto-to-cc" to # auto-populate the To: and Cc: trailers based on the code being # modified. Signed-off-by: Atish Patra <[email protected]> --- Changes in v2: - Moved the low priority RAS errors to different(lower) priority segment. - Added another patch related to firmware feature lock status. --- b4-submit-tracking --- # This section is used internally by b4 prep for tracking purposes. { "series": { "revision": 2, "change-id": "20241218-arc_review_comments-74b5242311da", "prefixes": [], "history": { "v1": [ "[email protected]" ] } } }
As per the ARC review feedbacks, the current functions using base and mask for batch mode operations on triggers doesn't describe the usage of base and mask. Provide additional text to clarify that. Signed-off-by: Atish Patra <[email protected]>
Signed-off-by: Atish Patra <[email protected]>
While the current fwft description says, it controls firmware features, it enable/disables bunch of hardware features as well. Provide additional clarification in the extension definition to avoid ambiguity. Reviewed-by: Clément Léger <[email protected]> Signed-off-by: Atish Patra <[email protected]>
As per the ARC feedback, When supervisor mode is there, medeleg must exists. There is no SBI extension without supervisor mode. Thus, medeleg presence related text is redundant. Reviewed-by: Clément Léger <[email protected]> Signed-off-by: Atish Patra <[email protected]>
Signed-off-by: Atish Patra <[email protected]>
As per the ARC review feedback, it was suggested that we should support both low priority and high priority SSE events. Introduce additional IDs for the low priority and mark the current ones as high priority. Signed-off-by: Atish Patra <[email protected]>
Some of the content from the write_attributes are copied from the read_attributes which is not correct. Fix the description. Signed-off-by: Atish Patra <[email protected]>
Signed-off-by: Atish Patra <[email protected]>
As per the ARC review feedback, it was suggested that the supervisor software should be able to distinguish between denial reasons if it was due to locked. While at it, add some clarification about set operation when the requested and existing values are same. Signed-off-by: Atish Patra <[email protected]>
atishp04
force-pushed
the
arc_review_comments
branch
from
e989ab3 to
18378df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.