target/riscv: clear abstract_cmd_maybe_busy after commands
#1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a sufficient delay was used before reading `abstractcs` during the batch execution, `dm->abstract_cmd_maybe_busy` was not cleared and the following call to `wait_for_idle_if_needed()` (e.g. on `resume`), would result in a call to `wait_for_idle()` performing a redundant read of `abstractcs`. While this is not a bug, it impedes the performance. Change-Id: I9d234ef6d53af96c60892d71247c10e631dfcc3b Signed-off-by: Evgeniy Naydanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a sufficient delay was used before reading
abstractcsduring the batch execution,dm->abstract_cmd_maybe_busywas not cleared and the following call towait_for_idle_if_needed()(e.g. onresume), would result in a call towait_for_idle()performing a redundant read ofabstractcs.While this is not a bug, it impedes the performance.
Change-Id: I9d234ef6d53af96c60892d71247c10e631dfcc3b