feat: support for issued currencies on Escrows and PaymentChannels #587
Conversation
|
A small video showing the functionality.. Please let me know if this is what were looking for. Screen.Recording.2023-02-07.at.4.47.31.PM.mov |
|
Please add testcases. |
|
I think the PR should be broken out into transaction updates and then one for account page changes. For the account page I agree with you that grouping by currency is odd. That is one reason we created the assets tab. @bugsbunnies do you think it makes sense to add an Escrows and Paychannel tabs so that we can show the breakdowns there? This would be similar to the account page for XRPScan. The amount column would show what currency and issuer it is using the component we use else where.
|
|
Concept after discussion with @ckniffen Transactions Escrow as a separate tab |
This looks really amazing! |
A thought: could the tabs not appear when a user doesn't have escrows or payment channels? Since most users won't have either. |
I like the idea of them always being there. That way we don't have to make requests to get them everytime the user visits an account page like we currently do. This will speed up load time. |
We already make the requests every time the user visits an account page. |
Only because we currently show the escrow and paychannel information outside of the tabs. I am suggesting this change could move it out. |
| try { | ||
| if (!date) { | ||
| return null | ||
| } | ||
| return new Intl.DateTimeFormat(lang, options).format(date) | ||
| } catch { |
There was a problem hiding this comment.
What does this try-catch block catch that wasn't caught before? Seems better to solve the root cause instead of using this blanket fix.
|
Looks like tests are currently failing on this PR. |
|
For reference: |
High Level Overview of Change
Updates to the explorer to reflect the changes made by amendment xls34d.
Context of Change
Updated the Tx Description to reflect both XPR and currencies
Updated the account to update the escrow when the user changes the primary (current) currency.
Proposed XLS-34d spec can be found here: XRPLF/XRPL-Standards#112
Type of Change
TypeScript/Hooks Update
Before / After
Test Plan
Please review. I didn't do paychannels as I wanted to get your thoughts on the escrow. I dont like how its only the currency and not the issuer but the explorer only uses the currency so I think it might suffice unless you add that additional functionality.
If you do want to add that functionality in rippled we use
USD/rIssuerAddressfor theAmountstring.