Merge pull request #36 from ringpublishing/bugfix/iz-parameter

IZ is set only for O!Konto sso system name

Changelogs/1.5.4

@@ -0,0 +1,6 @@
+1.5.3 Release notes (2024-10-03)
+================================
+
+### Changes
+
+* IZ parameter set only when SSO system name equals 'O!Konto'

Example/RingPublishingTracking.xcodeproj/project.pbxproj

@@ -1350,7 +1350,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 1.5.3;
+				MARKETING_VERSION = 1.5.4;
 				PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.demo.RingPublishingTracking-Example.RingPublishingTracking";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				PROVISIONING_PROFILE_SPECIFIER = "";
@@ -1373,7 +1373,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 1.5.3;
+				MARKETING_VERSION = 1.5.4;
 				PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.demo.RingPublishingTracking-Example.RingPublishingTracking";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				PROVISIONING_PROFILE_SPECIFIER = "";

Example/RingPublishingTracking/Info.plist

@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>$(PRODUCT_BUNDLE_PACKAGE_TYPE)</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.5.3</string>
+	<string>1.5.4</string>
 	<key>CFBundleVersion</key>
 	<string>1</string>
 	<key>LSRequiresIPhoneOS</key>

RingPublishingTracking.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
     s.name         = "RingPublishingTracking"
-    s.version      = "1.5.3"
+    s.version      = "1.5.4"
 
     s.summary      = "SDK used to report events from mobile application"
     s.license      = { :type => 'Copyright. Ringier Axel Springer Polska', :file => 'LICENSE' }

Sources/RingPublishingTracking/Private/Constants.swift

@@ -45,4 +45,8 @@ struct Constants {
     // MARK: Video event
 
     static let videoEventParametersPrefix = "video"
+
+    // MARK: SSO system name
+
+    static let raspSsoSystemName = "O!Konto"
 }

Sources/RingPublishingTracking/Private/Decorator/Generic/UserDataDecorator.swift

@@ -31,7 +31,7 @@ final class UserDataDecorator: Decorator {
         }
 
         // IZ
-        if let userId = data.userId {
+        if let userId = data.sso?.logged.id, data.ssoSystemName == Constants.raspSsoSystemName {
             userDataParams["IZ"] = userId
         }
 

Tests/RingPublishingTrackingTests/DecoratorTests.swift

@@ -187,7 +187,7 @@ class DecoratorTests: XCTestCase {
         XCTAssertNil(params["IZ"], "IZ should be empty")
     }
 
-    func testParameters_userDataDecoratorCreated_returnedParametersAreCorrect() {
+    func testParameters_userDataDecoratorCreatedForNonOKontoSSO_returnedParametersAreCorrect() {
         // Given
         let userId = "12345"
         let email = "[email protected]"
@@ -202,6 +202,25 @@ class DecoratorTests: XCTestCase {
         eyJzc28iOnsibG9nZ2VkIjp7ImlkIjoiMTIzNDUiLCJtZDUiOiI5Mzk0MmU5NmY1YWNkODNlMmUwNDdhZDhmZTAzMTE0ZCJ9LCJuYW1lIjoiVGVzdCJ9fQ==
         """
 
+        XCTAssertEqual(params["RDLU"], expectedBase64, "RDLU should match")
+        XCTAssertTrue(params["IZ"] == nil, "IZ should be empty for SSO system name not equal to O!Konto")
+    }
+
+    func testParameters_userDataDecoratorCreatedForOKontoSSO_returnedParametersAreCorrect() {
+        // Given
+        let userId = "12345"
+        let email = "[email protected]"
+        let decorator = UserDataDecorator()
+
+        // Then
+        decorator.updateUserData(userId: userId, email: email)
+        decorator.updateSSO(ssoSystemName: "O!Konto")
+        let params = decorator.parameters
+
+        let expectedBase64 = """
+        eyJzc28iOnsibG9nZ2VkIjp7ImlkIjoiMTIzNDUiLCJtZDUiOiI5Mzk0MmU5NmY1YWNkODNlMmUwNDdhZDhmZTAzMTE0ZCJ9LCJuYW1lIjoiTyFLb250byJ9fQ==
+        """
+
         XCTAssertEqual(params["RDLU"], expectedBase64, "RDLU should match")
         XCTAssertEqual(params["IZ"], userId, "IZ should match")
     }