Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid input issues in some apps #1411

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: avoid input issues in some apps #1411

wants to merge 3 commits into from

Conversation

CDHJS
Copy link

@CDHJS CDHJS commented Oct 26, 2024

注释掉了Composition.cpp中的pRangeComposition->SetText(ec, TF_ST_CORRECTION, L" ", 1);

pRangeComposition->SetText(ec, TF_ST_CORRECTION, L" ", 1);

可避免Firefox系浏览器部分情况无法输入问题 #1144
可能也能解决 #1406 所提到的部分问题

@mirtlebot
Copy link

/* WORKAROUND:
* CUAS does not provide a correct GetTextExt() position unless the
* composition is filled with characters. So we insert a zero width space
* here. The workaround is only needed when inline preedit is not enabled.
* See https://github.com/rime/weasel/pull/883#issuecomment-1567625762
*/

这个空格是什么情况下有用?我试着去掉空格编译了一下,Chrome、Notepad 等应用都是正常定位的,是有些应用不行吗 @fxliang

@fxliang
Copy link
Contributor

fxliang commented Oct 28, 2024

/* WORKAROUND:
* CUAS does not provide a correct GetTextExt() position unless the
* composition is filled with characters. So we insert a zero width space
* here. The workaround is only needed when inline preedit is not enabled.
* See https://github.com/rime/weasel/pull/883#issuecomment-1567625762
*/

这个空格是什么情况下有用?我试着去掉空格编译了一下,Chrome、Notepad 等应用都是正常定位的,是有些应用不行吗 @fxliang

这个旧代码一直都是空格,我是试过改成零宽空格但是不太好用后来又改回空格了。

@fxliang
Copy link
Contributor

fxliang commented Nov 19, 2024

如果要合并,这个_inlinePreeditEnabled就是没有用的状态了,还有下面的一个位置也是要调整。其他,我觉得再观察一段时间再看?
另外我试过一下firefox的设置窗口里面,这样一样没有解决问题的,Windows 10 64bit

@CDHJS
Copy link
Author

CDHJS commented Nov 19, 2024

如果要合并,这个_inlinePreeditEnabled就是没有用的状态了,还有下面的一个位置也是要调整。 其他,我觉得再观察一段时间再看? 另外我试过一下firefox的设置窗口里面,这样一样没有解决问题的,Windows 10 64bit

在我的系统上(Windows 10 22H2)Floorp 11.20.0 (64 位) | Firefox: 128.5.0和Firefox 132.0.2设置界面都正常打字且定位正常,使用GitHub Actions的编译。
至于其它需要调整的内容,我并不会C++,我只是找到出错的地方并注释掉了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants