Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Change constructor visibility in SpeedOrPace class #105

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

rohandhiman03
Copy link
Collaborator

Adjusted the visibility of the constructor in the SpeedOrPace abstract inner static class from public to protected. This aligns with best practices for abstract classes and clarifies its intended use.

Ref: Issue regarding the visibility of the constructor in SpeedOrPace

Thanks for your contribution.

PLEASE REMOVE

To support us in providing a nice (and fast) open-source experience:

  1. Verify that the tests are passing
  2. Check that the code is properly formatted (using AndroidStudio's autoformatter)
  3. Provide write access to the branch
  4. If the PR is not ready for review, please submit it as a draft

PLEASE REMOVE

Describe the pull request
A clear and concise description of what the pull request changes/adds.

Link to the the issue
(If available): The link to the issue that this pull request solves.

License agreement
By opening this pull request, you are providing your contribution under the Apache License 2.0 (see LICENSE.md).

Note: new dependencies/libraries
Please refrain from introducing new libraries without consulting the team.

Adjusted the visibility of the constructor in the `SpeedOrPace` abstract inner static class from public to protected. This aligns with best practices for abstract classes and clarifies its intended use.

Ref: Issue regarding the visibility of the constructor in `SpeedOrPace`
@rohandhiman03 rohandhiman03 linked an issue Oct 12, 2023 that may be closed by this pull request
@rohandhiman03
Copy link
Collaborator Author

Change constructor visibility in SpeedOrPace class

Adjusted the visibility of the constructor in the SpeedOrPace abstract inner static class from public to protected. This aligns with best practices for abstract classes and clarifies its intended use.

Ref: Issue regarding the visibility of the constructor in SpeedOrPace

@rohandhiman03 rohandhiman03 merged commit d2c7fb5 into main Oct 12, 2023
2 of 3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change SpeedOrPace constructor's visibility to protected
1 participant